Equinix fix matching maintenance_id in alternative email subject line#411
Merged
jvanderaa merged 9 commits intonetworktocode:developfrom May 6, 2026
Merged
Equinix fix matching maintenance_id in alternative email subject line#411jvanderaa merged 9 commits intonetworktocode:developfrom
jvanderaa merged 9 commits intonetworktocode:developfrom
Conversation
…tenance_id Moving forward, maintenance ID's for Equinix are in the format of CHG[0-9]+
Support old and new maintenance_id format; only fall back on matching for CHG[0-9]+ in case maintenance_id is not matched between brackets
i3dnet-akoopen
requested review from
glennmatthews,
jvanderaa,
pke11y and
scetron
as code owners
Changelog message
Contributor
|
A few updates for this:
|
Contributor
Author
|
I've made the requested changes, also added a new test (equinix10.eml with associated JSON output). The tests on my machine seems to run OK. |
Contributor
Author
|
Added another Equinix test, but only for parsing email subject (equinix11_subject.eml) |
jvanderaa
reviewed
May 6, 2026
Contributor
jvanderaa
left a comment
jvanderaa
left a comment
There was a problem hiding this comment.
A couple of small nits in the comments, no issue. One change in the double assignment and we will be good on this one.
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Co-authored-by: Josh VanDeraa <josh@josh-v.com>
Contributor
Author
|
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equinix seems to be not consistent with their email subject lines, causing an issue matching the maintenance_id. Recent examples include:
COMPLETED - Remedial Emergency Maintenance - SG Metro Area Network Maintenance - 04-APR-2026 [CHG0124084]
Service Impacting - Remedial - Dark Fiber Activity - SG Metro Area - Network Maintenance - 03-MAY-2026 - CHG0125903
The current parser is looking for a string between square brackets, but that will not work in the second email subject line. Proposal is to fall back on looking for the string CHG[0-9]+ as Equinix has recently switched to this format for announcing maintenances/changes.